Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor taxonomies saving process #9

Open
wants to merge 5 commits into
base: v5.0
Choose a base branch
from

Conversation

netzgestaltung
Copy link
Collaborator

Remove integer validation that does not work when slugs are used. Using slugs is OK for wp_set_object_terms() Docs. Also mixing with array seems no problem. We can rely on the API to take it.

I simple added the filter at the end anyway so the filter can be used at all time even if you are using a select-menu field.
I don't know how that would change the interface to add hooks or fields but that does not seem to work at all.

With that code i managed to get my custom dynamic dropdown using slugs inserted into the post.

@netzgestaltung netzgestaltung marked this pull request as draft December 7, 2020 11:58
@netzgestaltung
Copy link
Collaborator Author

Found a better readable version

@netzgestaltung netzgestaltung marked this pull request as ready for review December 7, 2020 12:04
@netzgestaltung netzgestaltung marked this pull request as draft December 8, 2020 03:32
@netzgestaltung netzgestaltung marked this pull request as ready for review December 8, 2020 04:13
@netzgestaltung
Copy link
Collaborator Author

Please review.

@aurovrata aurovrata changed the base branch from master to v5.0 December 16, 2020 10:02
@aurovrata
Copy link
Owner

I realise this is an old PR, but is this still required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants